guysoft / FullPageOS

A raspberrypi distro to display a full page browser on boot
GNU General Public License v3.0
3.86k stars 237 forks source link

unclutter instead of xdotools #42

Closed dhhdev closed 8 years ago

dhhdev commented 8 years ago

Looking through the code, I noticed FullPageOS is using xdotools to move the mouse off the screen. I would just argue that unclutter would be a bit more clean - and probably more lightweight. Is xdotools used for anything else?

FullPageOS/src/filesystem/home/pi/scripts/run_onepageos

#!/bin/bash
xset s off         # don't activate screensaver
xset -dpms         # disable DPMS (Energy Star) features.
xset s noblank     # don't blank the video device

matchbox-window-manager &
unclutter &
x11vnc -many -rfbauth /home/pi/.vnc/passwd &
while true
do
    if [ $(curl -sL -w "%{http_code}\\n" "http://localhost/FullPageDashboard" -o /dev/null) == "200" ]; then
      (sleep 15 ; /home/pi/scripts/fullscreen) &
      chromium-browser --kiosk --app=$(head -n 1 /boot/fullpageos.txt)
    fi
    sleep 1
done
tailorvj commented 8 years ago

As you can see in previous threads regarding the mouse arrow issue, we intend to use unclutter in future releases. Please feel free to implement and send a pull request

Kind regards, Tailor

dhhdev commented 8 years ago

Awesome. I just wasn't sure if xdotools wasn't used for any other automatization. I'm actually just making a dev environment on my old Raspberry Pi. (The first one. Jessie Lite Raspbian.)

I'll of course share whatever I might fix in the process of my own project. :-)