guysoft / FullPageOS

A raspberrypi distro to display a full page browser on boot
GNU General Public License v3.0
3.86k stars 237 forks source link

DISPLAY_ORIENTATION Not working on Bullseye Stable Build #561

Closed salpoosi closed 3 months ago

salpoosi commented 4 months ago

RPI 4B Bullseye Stable Build 0.13.0

I'd like to use screen rotation, but it didn't work. I found an issue in the file, so I'm providing the correct content for it to function properly. Please apply the changes.

/home/pi/scripts/start_gui

-if ["${DISPLAY_ORIENTATION}" != 'normal']; +if [ "${DISPLAY_ORIENTATION}" != 'normal' ];

-if ["${DISABLE_POWER_MANAGEMENT}" == #'yes']; +if [ "${DISABLE_POWER_MANAGEMENT}" == 'yes' ];

guysoft commented 3 months ago

Hey, it looks like you made changes to the code. This is the current source (which was not changed the past 2 years: https://github.com/guysoft/CustomPiOS/blob/devel/src/modules/gui/filesystem/opt/scripts/start_gui#

#!/bin/bash

# Stop the screen from turning off when idle.
DISABLE_POWER_MANAGEMENT=yes

# Rotate screen if needed, see 'xrandr -h' for options.
DISPLAY_ORIENTATION=normal

if [[ "${DISPLAY_ORIENTATION}" != 'normal' ]];
then
  xrandr --orientation ${DISPLAY_ORIENTATION}
fi

if [[ "${DISABLE_POWER_MANAGEMENT}" == 'yes' ]];
then
  xset s off         # don't activate screensaver
  xset -dpms         # disable DPMS (Energy Star) features.
  xset s noblank     # don't blank the video device
fi

matchbox-window-manager &

GUI_SESSION_PLACEHOLDEFR

There was a fix here: https://github.com/guysoft/CustomPiOS/commit/8bbe19d0ce87c4969207663e5f2ea682f6c895ae

JonathanPorta commented 3 months ago

I wanted to chime in, mainly for anyone else having this issue, and mention that as of 5/23/24, when using the Raspberry Pi Imager, the stable version of FullPageOS available with that tool was built on 2022-02-07 and does not yet contain the bug fix @guysoft mentioned. 1

@guysoft Also, thanks a ton for this project. It's great!

salpoosi commented 3 months ago

I think FullPageOS is a very good project and has features that are not at all inferior to other commercial versions. While I am aware that the source has already been fixed in CustomPiOS, the bug still persists in the official Raspberry Pi distribution of FullPageOS, and I would have liked to see them reflected in the official distribution image. Thank you for this project. @guysoft

guysoft commented 3 months ago

@JonathanPorta @salpoosi Thanks for the kind words. It really helps when there are so many bugs and issues to get control over to hear it :)

If you can confirm that the issue is fixed in 0.14.0 RC1 which has an issue tracking it here: #540 I would very much want to release it. It looks like the wpasupplicant issue there is something general and this means that its likely good enough for release.

nordurljosahvida commented 3 months ago

@salpoosi @guysoft @JonathanPorta I'm very sorry to tag you guys, I've bee trying to work this issue for the better part of three days and my brain is on fire.

Raspi 4. Original 7" screen.

Boots as landscape, need to rotate view - and of course touch interface too - to portrait.

I was using stable version on raspi, display_rotate / lcd_rotate didn't work. Disabling dtoverlay made the screen black.

I luckily found this post, so I downloaded 0.14.0 RC1 no-acceleration variant, flashed it now.

What I don't understand is, once I flash this version, which of the 37000 ways of rotating the screen I need to use.

Is it by running this script from the booted os?

Thank you so much in advance!

guysoft commented 2 months ago

Hey, there are several ways to do this. I don't have a running instance to test it for you though.

Maxinoha1 commented 5 days ago

Can I ask for advice on how to set the rotation by 90 degrees - I tried it: DISPLAY_ORIENTATION=right but after reboot the image did not rotate. I also tried to update the entire content of the file /home/pi/scripts/start_gui, see the above error.

guysoft commented 13 hours ago

@Maxinoha1 Did you try it with the nightly? Version 0.13.0 I think has an issue with it.