guysoft / OctoKlipperPi

OctoPi klipper using the CustoPiZer distro builder
GNU General Public License v3.0
89 stars 15 forks source link

Refactored some stuff & made it more CustoPiZer-ic #1

Closed foosel closed 3 years ago

foosel commented 3 years ago

All in all that reduced the actual build script by around a 100 lines and not only made it more readable but also better reusable and more in line with the idea of CustoPiZer.

Personally I'd also not have put the stuff into a src folder (see https://github.com/OctoPrint/OctoPi-UpToDate) because there really isn't that much there apart from scripts and files but YMMV.

Build was tested locally (docker run ...), flashed to a Pi on my testrig, booted and verified that the Klipper server is running and OctoPrint/the plugin able to connect to it.

Sidenote: I have my doubts about the image shrinking working as it should, I cannot imagine that the stuff added by this build really fills up the whole 2GB. I'll take another look on CustoPiZer/OctoPi at that ASAP.

guysoft commented 3 years ago

Cool, merged, I still need to figure out how to do the github actions. I am still not sure that CustoPiZer is the way to go here and not CustomPiOS. Which I already have up and building. I wanted to make this repo and put this comment, because if anyone else is reading this who is not @foosel or me it would help me if you voice your preference too.