search

guysoft / OctoPi

Scripts to build OctoPi, a Raspberry PI distro for controlling 3D printers over the web
GNU General Public License v3.0
2.45k stars 368 forks source link

Compatibility for ws281x on Ubuntu 64 #724

Closed Willmac16 closed 3 years ago

guysoft commented 3 years ago
  1. Can you please add a pushd/popd around it so if the working dir changes it wont break or put files in the wrong place? Also it makes it hard to understand where the files are added.
  2. Why are you touching cmdline.txt?
Willmac16 commented 3 years ago
  1. I fixed it so the file changes now have full paths.
  2. The current version of the ws281x plugin required both files to function; however, I can also try out the dev version of the plugin and we could only bring over the changes needed for it.
guysoft commented 3 years ago

My question was why are you running sudo touch /boot/cmdline.txt? Touch would create the file if empty, and will change the modification date if it exists, why would you touch it for the plugin to work?

cp2004 commented 3 years ago

Mostly because of my mistakes, the FileNotFound error was not handled and caused the plugin to kind of crash.

guysoft commented 3 years ago

Ok, can it be removed?

cp2004 commented 3 years ago

Yes, it should be fixed in the plugin rather than here. The SPI stuff makes more sense to have set up, the /boot/config.txt and /boot/cmdline.txt I should handle in the plugin, it is used for the setup wizard to do things like actually enabling SPI etc. I will try the image at some point.

guysoft commented 3 years ago

Ok, remove that touch and I should be able to merge this.

guysoft commented 3 years ago

Thanks! Can be tested next nightly

guysoft commented 3 years ago

This breaks on Ubuntu, reverting

sudo ln /boot/config-5.8.0-1006-raspi /boot/config.txt
ln: failed to access '/boot/config-5.8.0-1006-raspi': No such file or directory
+ exit 1