guysoft / OctoPi

Scripts to build OctoPi, a Raspberry PI distro for controlling 3D printers over the web
GNU General Public License v3.0
2.49k stars 369 forks source link

Fix HAProxy warning on wrong timeout abrreviation #778

Closed canihavesomecoffee closed 2 years ago

canihavesomecoffee commented 2 years ago

I was fixing my OctoPi install after doing a dist-upgrade (buster to bullseye) and breaking haproxy in the process... I fixed that issue by replacing my haproxy cfg with the one that's located on master here, and haproxy restarted, but threw a warning.

Mar 28 19:26:51 octopi haproxy[747]: [WARNING] 086/192651 (747) : unexpected character 'i' after the timer value '15min', only (us=microseconds,ms=milliseconds,s=seconds,m=minutes,h=hours,d=days) are supported. This w…or in next versions.
Mar 28 19:26:51 octopi haproxy[747]: [WARNING] 086/192651 (747) : unexpected character 'i' after the timer value '15min', only (us=microseconds,ms=milliseconds,s=seconds,m=minutes,h=hours,d=days) are supported. This w…or in next versions.

This PR addresses that.

Information on the system:

pi@octopi:~ $ haproxy -v
HA-Proxy version 2.2.9-2+rpi1+deb11u3 2022/03/17 - https://haproxy.org/
Status: long-term supported branch - will stop receiving fixes around Q2 2025.
Known bugs: http://www.haproxy.org/bugs/bugs-2.2.9.html
Running on: Linux 5.10.103-v7+ #1529 SMP Tue Mar 8 12:21:37 GMT 2022 armv7l

Running OctoPi 0.17.0 (with a manual upgrade to Debian Bullseye)

guysoft commented 2 years ago

Thanks for catching that!

guysoft commented 2 years ago

Also docs for future reference: https://cbonte.github.io/haproxy-dconv/2.0/configuration.html#5.3.2-timeout