search

guysoft / pi-imager

Other
19 stars 1 forks source link

make ci/cd work #2

Closed guysoft closed 2 years ago

guysoft commented 2 years ago

The images need to be built for:

guysoft commented 2 years ago

There is a working github action that builds the .deb linux version

Note - it might be a good idea to rename the deb pacakge to pi-imager, so you can install both rpi-imager and pi-imgaer alongside

Screenshot_20220203_012836

kingosticks commented 2 years ago

https://github.com/marketplace/actions/install-qt might be helpful, especially for the Windows side. I didn't realise Github actions had support for Windows environments - cool!

kingosticks commented 2 years ago

Also, the github Windows env comes with MSYS2 already so should be able to take the easier pre-built SSL option rather than compiling from source, as mentioned here.

Then there appeared to be this action available for the Nullsoft scriptable install system.

Lastly there is https://github.com/dlemstra/code-sign-action but I've zero idea about Windows code signing.

Note, I have never tried any of this! I am not really a Windows person.

guysoft commented 2 years ago

I am stuck with OpenSSL not getting detected: Been bashing against it the past few days and it just wont build from source, and won't take the pre-build binaries https://github.com/raspberrypi/rpi-imager/issues/351

guysoft commented 2 years ago

Windows builds now in the windows-ci branch, and generates rpi-imager.exe but for some reason when I run it on my VM it also shipps qt5.dll and a bunch of them that it does not ship on github actions, no idea why.

Error copying file "D:/a/pi-imager/pi-imager/qt/Qt/5.15.2/mingw81_32/lib/cmake/Qt5/../../../bin/libcrypto-1_1.dll" to "D:/a/pi-imager/pi-imager/build/deploy".

Got it, it should build soon for windows, unsigned and no installer, but good enough :)

guysoft commented 2 years ago

Windows CI/CD works, next one is mac.

guysoft commented 2 years ago

Mac builds and signs now. it makes an .app and not a dmg, but good enough for running. Closing for now. Once I get something that is useful it would make sense to reopen or open an issue per OS. An appimage might also make sense, it was requested here: https://github.com/raspberrypi/rpi-imager/issues/350

guysoft commented 2 years ago

Released FYI