search

guysoft / pi-imager

Other
17 stars 1 forks source link

Remove Telemetry? #4

Closed kingosticks closed 2 years ago

kingosticks commented 2 years ago

Does it make sense to keep the telemetry? Would be sad to upset the RPi team with stuff they don't want.

guysoft commented 2 years ago

I guess that makes a good idea. I say we first get CI/CD working on enough distros so its easy to release and then ask them once this repo is useful.

guysoft commented 2 years ago

Well its back in question. @ghollingworth do you guys have any preference? Persnoally I don't mind leaving it on if it gives us statistics and if some image becomes popular

ghollingworth commented 2 years ago

Indeed, leaving it in would enable you to look at the stats, you could also change the version numbering scheme to identify your version as separate from the rpi-imager version (i.e. use guysoft-1.7.1 for example).

Gordon

guysoft commented 2 years ago

Thanks for the info. I might change the version name so it does not mix. Will see when I have time to dig in to that

guysoft commented 2 years ago

Just to note the 1.7.1 is currently hardcoded:

set(IMAGER_VERSION_MAJOR 1)
set(IMAGER_VERSION_MINOR 7)
set(IMAGER_VERSION_STR "${IMAGER_VERSION_MAJOR}.${IMAGER_VERSION_MINOR}.1")
set(IMAGER_VERSION_CSV "${IMAGER_VERSION_MAJOR},${IMAGER_VERSION_MINOR},1,0")
add_definitions(-DIMAGER_VERSION_STR="${IMAGER_VERSION_STR}")
add_definitions(-DIMAGER_VERSION_CSV=${IMAGER_VERSION_CSV})

Note in windows the FILEVERSION and PRODUCTVERSION have to be numbers.

I am changing to 1.7.1-unofficial.

guysoft commented 2 years ago

Done: https://github.com/guysoft/pi-imager/releases