guyzmo / git-repo

Git-Repo: CLI utility to manage git services from your workspace

https://webchat.freenode.net/?channels=#git-repo

Other

842 stars 85 forks source link

Automatic Browser detection using Python built-ins #161

Closed fa7ad closed 7 years ago

fa7ad commented 7 years ago

PR as asked #159 :grin:

guyzmo commented 7 years ago

Thank you for the PR 🙌♥

fa7ad commented 7 years ago

Should be fine now

guyhughes commented 7 years ago

The github issue that brought this about has been updated: https://github.com/github/hub/issues/1473

xdg-open isn't deprecated:

The fact that xdg-open calls gvfs-open (which then shows the message) before gio open is a bug caused by that deprecation and is fixed in xdg-utils 1.1.2.

That said, using the webbrowser stdlib module is probably an improvement anyway.

fa7ad commented 7 years ago

¯\(ツ)\/¯

guyzmo commented 7 years ago

I consider this solution 👌 and thus I marked the patch as ready and it will make it to the 1.11 milestone.

There's a bunch of updates I need to take care of as well and it'd be great if I could find the time to add features (issues, gpg, ssh are my goal).