search

guzba / zippy

Pure Nim implementation of deflate, zlib, gzip and zip.
MIT License
246 stars 29 forks source link

implement ZipArchive addFile method #53

Closed brendo-m closed 1 year ago

brendo-m commented 1 year ago

Add a new method for adding a single file into a ZipArchive

brendo-m commented 1 year ago

Any update here?

guzba commented 1 year ago

Hello and thanks for the PR. I see how this proc could be useful and have no concerns about adding it.

Note that the file this is editing, ziparchives_v1.nim is the original implementation I did, which has been replaced by ziparchives.nim. The current version does not yet support writing zip archives though so this _v1 is still needed. Someday I intend to revisit and improve writing zip archives, as I already did for reading them, but it has not happened yet.

guzba commented 1 year ago

This has been tagged in https://github.com/guzba/zippy/releases/tag/0.10.6