search

guzba / zippy

Pure Nim implementation of deflate, zlib, gzip and zip.
MIT License
246 stars 29 forks source link

`nimPreviewHashFarm` breaks concatenation test #78

Closed c-blake closed 1 month ago

c-blake commented 1 month ago

The error more specifically is this one:

tests/test_ziparchives_read.nim(46, 5) `entry == entries[numEntries]`

I don't understand why zip file catenation would depend upon string hasher order, but it is one of a couple things holding up activating nimPreviewHashFarm by default. So, if you could look into it soon, that would be awesome.

guzba commented 1 month ago

The issue here is that the test assumed the Table order was stable, but really I should use OrderedTable. I'll have a fix for this tagged in a little bit.

guzba commented 1 month ago

Tagged in https://github.com/guzba/zippy/releases/tag/0.10.14

c-blake commented 1 month ago

Thanks, for the quick work, man, esp. for the rapid release tag.