search

guzba / zippy

Pure Nim implementation of deflate, zlib, gzip and zip.
MIT License
248 stars 29 forks source link

fix: integer-overflow on arm 32-bit systems #82

Closed saemideluxe closed 1 month ago

saemideluxe commented 1 month ago

I experience a very similar issue as #3 but when using extractAll for zip archives. My error message was

value out of range: 2323877985 notin -2147483648 .. 2147483647 [RangeDefect]

This PR fixes the issue, but I am not sure if there are other implications with the uint cast.

guzba commented 1 month ago

Thanks for the fix!

guzba commented 1 month ago

This fix is tagged in release 0.10.15

saemideluxe commented 1 month ago

Cool, thanks for the quick fix. Also btw. thanks for writing and maintaining this, I am using this now already in the second production-grade project at work.