Ability to pass constructor options to Raven constructor

guzru / winston-sentry

Sentry transport for winston logger for node js

MIT License

82 stars 37 forks source link

Closed dhritzkiv closed 8 years ago

dhritzkiv commented 8 years ago

Pass transport constructor options to raven constructor after parsing transport-specific options.

Expands on #24, but allows any property to be passed to the Raven constructor.

The delete options.x lines may not be necessary (as including those properties may not have any side-effects), but just in case…

adambiggs commented 8 years ago

Nice! I like how this solution lets winston-sentry take advantage of new features added to Raven without any code changes. I'm going to close #24.

Any word on merging this @guzru?

Peter-Barrett commented 8 years ago

Looks good to me 👍

dhritzkiv commented 8 years ago

@Peter-Barrett any chance for an npm release of this soon?

shaharke commented 8 years ago

@dhritzkiv released to npm