Closed adambiggs closed 8 years ago
@guzru @shaharke Can somebody take a look at this PR and merge it?
@adambiggs I like the refactoring. Notice that this change is not backwards compatible since globalTags
is ignored. I suggest we make it backwards compatible before merging.
@shaharke the reason for the breaking change is that options are now passed directly to the raven
client. So the winston-sentry
options API should match raven
's API.
The advantage is that new options added to raven
in future releases should "just work" without any additions to winston-sentry
.
@adambiggs I understand, but that would break users' code. The need to move globalTags
into tags
.
@shaharke ok, how about if i add something like options.tags = options.tags || options.globalTags
for backward compatibility.
@adambiggs published as 0.1.2
Thanks! 🍻
In this PR
raven
to the latest versionunderscore
tolodash
this.defaults
object_.defaultsDeep()
for compatibility with future raven featuresBreaking Change
All options passed to
winston-sentry
now mirror those used byraven
. This means the previousglobalTags
option is now namedtags
.