guzru / winston-sentry

Sentry transport for winston logger for node js
MIT License
82 stars 37 forks source link

Update raven and some other general improvements #30

Closed adambiggs closed 8 years ago

adambiggs commented 8 years ago

In this PR

All options passed to winston-sentry now mirror those used by raven. This means the previous globalTags option is now named tags.

grimurd commented 8 years ago

@guzru @shaharke Can somebody take a look at this PR and merge it?

shaharke commented 8 years ago

@adambiggs I like the refactoring. Notice that this change is not backwards compatible since globalTags is ignored. I suggest we make it backwards compatible before merging.

adambiggs commented 8 years ago

@shaharke the reason for the breaking change is that options are now passed directly to the raven client. So the winston-sentry options API should match raven's API.

The advantage is that new options added to raven in future releases should "just work" without any additions to winston-sentry.

shaharke commented 8 years ago

@adambiggs I understand, but that would break users' code. The need to move globalTags into tags.

adambiggs commented 8 years ago

@shaharke ok, how about if i add something like options.tags = options.tags || options.globalTags for backward compatibility.

shaharke commented 8 years ago

@adambiggs published as 0.1.2

adambiggs commented 8 years ago

Thanks! 🍻