search

guzru / winston-sentry

Sentry transport for winston logger for node js
MIT License
82 stars 37 forks source link

Check if transport is silent #37

Closed jnv closed 2 years ago

jnv commented 7 years ago

This enables Winston's property silent to silence the transport during the setup.

niftylettuce commented 7 years ago

Please accept this PR @guzru - if you'd like me to help maintain this package let me know (just grant me collaborator status and then run npm owner add niftylettuce. Thank you.

niftylettuce commented 7 years ago

hey @jnv you can probably close this issue and just use the package winston-raven-sentry - see https://github.com/guzru/winston-sentry/issues/49 or visit https://github.com/niftylettuce/winston-raven-sentry for complete documentation!

jnv commented 7 years ago

@niftylettuce Thanks, I'm glad someone took over. I will keep this PR open for now, so the message remains visible.

mgara commented 5 years ago

@niftylettuce @jnv @guzru please can we have our PRs verified, maybe switch owner for the package... do you guys know if there is any official sentry winston package ? or we just go ahead and maintain this package ? thanks a lot ! I pushed a PR yesterday with the new @sentry/node module please let me know if it's rejected or I can do anything to make it better. Feel free to review the code ! I'm using it write now as suggested in my release 

    "winston-sentry": "git@github.com:mgara/winston-sentry.git#5.4.3-rc1"
niftylettuce commented 5 years ago

@mgara I'm not sure why you are using Sentry; there are so many issues with it. Too much bloat and the interface is unusable. I would highly recommend you to use Cabin @ https://cabinjs.com instead.

jnv commented 5 years ago

@mgara I am not sure how I can help, I just opened this PR. AFAIK there is no official Sentry transport for Winston. If you wish to become a maintainer of this package, I think @shaharke might help you. Otherwise you can just maintain your fork and publish it on npm either under new name, or in your namespace.

jnv commented 5 years ago

@niftylettuce Very subtle self-promotion. 😉