search

guzzle / guzzle-services

Provides an implementation of the Guzzle Command library that uses Guzzle service descriptions to describe web services, serialize requests, and parse responses into easy to use model structures.
MIT License
253 stars 78 forks source link

Improve the construction of baseUri in Description #112

Closed Konafets closed 7 years ago

Konafets commented 8 years ago

A given baseUrl in service description is constructed like this: $this->baseUrl = new Uri(isset($config['baseUrl']) ? $config['baseUrl'] : '');

Why store an empty string when no a baseUrl given instead of storing an empty URI()?

$this->baseUrl = isset($config['baseUrl']) ? new Uri($config['baseUrl']) : new Uri();

Konafets commented 7 years ago

Fixed in 85c3969