What is the correct type of Parameter static option

guzzle / guzzle-services

Provides an implementation of the Guzzle Command library that uses Guzzle service descriptions to describe web services, serialize requests, and parse responses into easy to use model structures.

MIT License

253 stars 78 forks source link

What is the correct type of Parameter static option #113

Closed Konafets closed 7 years ago

Konafets commented 8 years ago

The service description knows a static option. From the header doc:

static: (bool) Set to true to specify that the parameter value cannot be changed from the default.

However, in the UnitTests the static option gets a string static! assigned.

Proposal: If static is boolean, we should change the test and also change the method name from getStatic() to isStatic().

The service description definition clearly defines static as type of boolean.