Removed useless code - setting config defaults

guzzle / guzzle-services

Provides an implementation of the Guzzle Command library that uses Guzzle service descriptions to describe web services, serialize requests, and parse responses into easy to use model structures.

MIT License

253 stars 78 forks source link

Removed useless code - setting config defaults #157

Closed supersmile2009 closed 6 months ago

supersmile2009 commented 6 years ago

This code is useless because:

['defaults'] are never saved into a $this->config variable after this.
getConfig() will return an empty array anyway if config key isn't set. Therefore we don't need to fix №1 by saving new $config into $this->config

GrahamCampbell commented 6 months ago

Sorry this took so long to get to, I only took over maintenance of this package in the last couple of years, and the plans for it are just to keep it compatible with new PHP versions and new Guzzle versions. I'm not sure either you nor I want/ned this feature any-more/have the time/head-space to do anything with this PR, and so I'm going to go ahead and close this out for now. If you feel differently, please let me know.