Update to Guzzle 7 - Githubissues

guzzle / guzzle-services

Provides an implementation of the Guzzle Command library that uses Guzzle service descriptions to describe web services, serialize requests, and parse responses into easy to use model structures.

MIT License

253 stars 78 forks source link

Update to Guzzle 7 #174

Closed bumbummen99 closed 3 years ago

bumbummen99 commented 4 years ago

As the title says. This will require https://github.com/guzzle/command/pull/40

Remove deprecated function Uri::resolve
Fix tests
Update for Guzzle 7

bumbummen99 commented 4 years ago

Tests working with "skyraptor/command": "dev-master"

Konafets commented 4 years ago

As guzzle/guzzle requires PHP 7.2, I would suggest to drop all PHP versions <7.2 and add 7.2, 7.3 and 7.4. What do you think?

bumbummen99 commented 4 years ago

@Konafets Personally i think support for EOL versions should not be priority anyways so +

elijahchancey commented 4 years ago

@bumbummen99 Do you or anyone else know how to fix the tests? Looks like there's a PHP version issue and a test Setup Issue.

bumbummen99 commented 4 years ago

@elijahchancey It just requires guzzle/command to also be patched, see the mentioned PR in the first post. The tests should work with it.

Konafets commented 4 years ago

Thanks for the work and progress on this PR. I am in the middle of renovating my new home and time is a valuable resource these days. I will take care of this and release a new version within the next days.

arthurkirkosa commented 4 years ago

Any timeline on this merge?

bumbummen99 commented 4 years ago

Any timeline on this merge?

@arthurkirkosa https://github.com/guzzle/guzzle-services/pull/174#issuecomment-700279604

digitv commented 3 years ago

I hope for soon merge...because of Laravel 8 as well :man_shrugging:.

elijahchancey commented 3 years ago

@Konafets please merge when you can! thanks

Konafets commented 3 years ago

Thanks @bumbummen99. I merged a modified version of this PR in 187b530b4ceaabf47dd3a42dbccfce2b979c27f7.

arthurkirkosa commented 3 years ago

Do you need to manually trigger packagist to pick up the new tag?