search

guzzle / promises

Promises/A+ library for PHP with synchronous support
MIT License
7.61k stars 116 forks source link

Add compatibility with PHPUnit 9.3 #118

Closed villfa closed 4 years ago

villfa commented 4 years ago

This is a required step to build the project with PHP8.

GrahamCampbell commented 4 years ago

Will conflict with https://github.com/guzzle/promises/pull/113.

villfa commented 4 years ago

@GrahamCampbell I have reworked the PR hoping this will make the merge easier

Nyholm commented 4 years ago

Could you please rebase this PR?

Nyholm commented 4 years ago

I started working on PHP8 another ago. I see that that PR is using PHPUnit 9.3.10 with the symfony phpunit bridge.

Have a look at #122. What are the pros/cons between that approach?

villfa commented 4 years ago

I started working on PHP8 another ago. I see that that PR is using PHPUnit 9.3.10 with the symfony phpunit bridge.

Have a look at #122. What are the pros/cons between that approach?

When I have originally open this PR I wanted to keep it as minimal as possible. Now that phpunit-bridge has been added I think it's not relevant to maintain this PR anymore. I'm closing it in favor of yours.

Nyholm commented 4 years ago

Yeah, I appreciate that.

This morning when I started with this library I had no plans of creating PHP8 support.

Thank you for you work.