search

guzzle / promises

Promises/A+ library for PHP with synchronous support
MIT License
7.61k stars 116 forks source link

Fix promise handling for Iterators of non-unique keys #77

Closed Tobion closed 7 years ago

Tobion commented 7 years ago

The keys of iterators may not be unique, e.g. using a Generator that yield 'foo' => 'bar'; yield 'foo' => 'baz'.

This currently failed because the pending array would just overwrite each one. This resulted in missing Guzzle requests in our case.

Tobion commented 7 years ago

Added a test.

@sagikazarmark please review

sagikazarmark commented 7 years ago

LGTM

Are you going to do any changes or I'm free to merge?

Tobion commented 7 years ago

It's ready

sagikazarmark commented 7 years ago

Great, thanks