Removes unnecessary static access modificator from callHandler

guzzle / promises

Promises/A+ library for PHP with synchronous support

MIT License

7.61k stars 116 forks source link

Removes unnecessary static access modificator from callHandler #83

Closed cleristonos closed 4 years ago

cleristonos commented 6 years ago

I think that static access modifier from callHandler is unnecessary and I had some problems because It is private . I removed it and I ran the tests successfully.

Tobion commented 5 years ago

@cleristonos Thanks for the PR. What problem does this solve that you mentioned? I don't see how this PR changes anything in behavior.

jeremeamia commented 5 years ago

I would not change this. Staticness here is an optimization, and likely defends against memory leaks.

GrahamCampbell commented 4 years ago

I agree with @jeremeamia. 👎 for merging this.