search

guzzle / promises

Promises/A+ library for PHP with synchronous support
MIT License
7.61k stars 116 forks source link

Fixed pthreads bug: "The promise was rejected" #91

Closed wolph closed 4 years ago

wolph commented 6 years ago

As far as I can quickly test, this minor change fixes this issue: https://github.com/guzzle/guzzle/issues/2066

Beyond that the guzzle library appears to work just fine within a pthreads environment :)

GrahamCampbell commented 4 years ago

Hmm, I think pthreads should fix its bug, actually, rather than having a work around. The code should already initialise to those values without you doing it again in the constructor.

Tobion commented 4 years ago

Closing as pthreads is not maintained anymore: https://github.com/krakjoe/pthreads/issues/929 So we also do not need to add workarounds for it.