gvalkov / python-evdev

Python bindings for the Linux input subsystem
https://python-evdev.rtfd.org/
BSD 3-Clause "New" or "Revised" License
334 stars 112 forks source link

ff: Fix up attack_length key typo in Envelope struct #148

Closed pmundt closed 3 years ago

pmundt commented 3 years ago

The Envelope struct defined an 'attach_length' key instead of the expected 'attack_length'. While the documentation was correct, any passed in 'attack_length' value was being silently dropped.

This was discovered when configuring a periodic sinusoidal effect and observing differences in the waveform in comparison to the C API.

Signed-off-by: Paul Mundt paul.mundt@adaptant.io

gvalkov commented 3 years ago

Thanks.