gvalkov / tornado-http-auth

Digest and basic authentication for Tornado
Apache License 2.0
19 stars 12 forks source link

fixed handling of stale nonces in the HTTP Digest Auth implementation #11

Open rhaberkorn opened 3 months ago

rhaberkorn commented 3 months ago

The stale=true attribute was not sent in the resulting challenge that the server sends, so clients/browsers would unnecessarily ask for the credentials again.

You may want to edit this change if you disagree with the way I pass on the information that the nonce is stale. Actually, I do not understand why you are throwing AuthError in DigestAuthMixin.verify_opaque() in the first place instead of always throwing DigestAuthMixin.SendChallenge().