gvas / knockout-jqueryui

Knockout bindings for the jQuery UI widgets.
http://gvas.github.com/knockout-jqueryui/
MIT License
103 stars 38 forks source link

dialog button handlers' "this" bound to dialog, not viewmodel #43

Open oising opened 9 years ago

oising commented 9 years ago

I see you've fixed up the events to get bound to the viewmodel, but the following binding does not work correctly:

<div data-bind="dialog: { isOpen: $root.isEditMode, buttons: { Save: $root.save} }"></div>

In the save function, this is bound to the jquery dialog, not the viewmodel.

RolfVeinoeSorensen commented 9 years ago

Did you ever get this problem solved. I am facing the same issue.

RolfVeinoeSorensen commented 9 years ago

I created a work around where I did not add the buttons through the handler but just added it to the dialog div like this: