gvegayon / parallel

PARALLEL: Stata module for parallel computing
https://rawgit.com/gvegayon/parallel/master/ado/parallel.html
MIT License
118 stars 26 forks source link

Stata 17 BE - Stata executable path not detected #96

Closed ArnaudKunzi closed 3 years ago

ArnaudKunzi commented 3 years ago

Dear all,

/gvegayon/parallel/parallel_setstatapath.mata needs to be updated to support Stata 17 basic edition executable name. On the BE edition, the executable path is not auto-detected and need to be manually specified:

image

The basic edition is the replacement of the previous version's IC edition. Here are the system values.

image image

Let me know if you need more info or any help with testing!

bquistorff commented 3 years ago

Typically we query c(flavor). Can you report what that returns? Eventually it'd be nice to know what the executable names are on Mac + Unix.

ArnaudKunzi commented 3 years ago

Run on stata 17BE:

image This tripped me up at first...

Stata's user guide [U] 5.2 gives a clarification: image

given that c(edition) is not defined in stata versions < 17, there will be probably a need to first check if c(version) >=17 , and then checking c(edition) or c(flavor) depending on the result. A tested alternative on Stata 15MP, 16IC and 17BE is:

di cond("`c(edition)'" != "", "`c(edition)'", "`c(flavor)'")

and 'correctly' returns IC in the two first cases or BE in the later case.

Eventually it'd be nice to know what the executable names are on Mac + Unix.

I would have loved to help more but I only have linux binaries up to v16 and no Mac. Can anyone else comment on this?

bquistorff commented 3 years ago

I just pushed an update to master. Could you reinstall from master and see if it auto-detects the version? Thanks

ArnaudKunzi commented 3 years ago

It works, thanks! image

I asked a colleague running Stata17BE on MacOS to help. Here are the outputs:

image

executable path is:

/Applications/Stata/StataBE.app/Contents/MacOS/StataBE

bquistorff commented 3 years ago

Thanks for checking on this. I've updated the MacOS section accordingly.