search

gvellut / jncep

Command-line tool to generate EPUB files for J-Novel Club pre-pub novels
GNU General Public License v3.0
43 stars 11 forks source link

Tool no longer appending "Complete" when downloading entire volume #19

Closed K-o-R closed 2 years ago

K-o-R commented 2 years ago

I have tried both passing a volume URL, e.g. jncep epub https://j-novel.club/series/hell-mode#volume-3 and also specifying a volume number e.g. jncep epub -p 3 https://j-novel.club/series/hell-mode but it doesn't seem to be recognising it as "complete".

gvellut commented 2 years ago

Thank you for your feedback.

The "Complete" info is not actually included in the API provided by J-Novel Club, so jncep fetches the j-novel.club webpage for the series, which contains a structure with the info (that the webpage uses for rendering).

But I I just saw that structure has been changed, at least for Hell Mode. I will update the code and make a new release soon.

K-o-R commented 2 years ago

Wonderful, thank you for your time :)

gvellut commented 2 years ago

I have made a new release. It should fix the issue you had.

(as an aside, I saw that JNC has added a new attribute for determining completeness to the API directly so the code is a bit simpler)