search

gvellut / jncep

Command-line tool to generate EPUB files for J-Novel Club pre-pub novels
GNU General Public License v3.0
43 stars 11 forks source link

[Feature Request] Download whole volume when last part is released #31

Closed pajoh closed 1 year ago

pajoh commented 1 year ago

Would it be possible to add a switch "Download whole volume on last part", that downloads both the last part like normal update, but also downloads the full volume.

I've done a quick fix locally for me that works, but would be nice if it was added so I don't have to apply the dirty fix each time I pull from here. It's not close to be good enough for a PR though.

gvellut commented 1 year ago

OK it can be added.

Even if it is not ready, you can send me your changes as a PR (I will arrange it if needed).

gvellut commented 1 year ago

Thank you for your PR. I have edited a little bit (refactored the surrounding function essentially). I have also changed the name of the option: It is called --whole-final (to match the Final suffix used in the generated EPUBs) and the env var is called JNCEP_WHOLE_FINAL. I will test some more and make a release soon.