Closed non-Jedi closed 11 months ago
I went ahead and forced upgrading to asks 3.0.0 locally (pip install -U asks
with venv activated), and jncep seems to be working as expected thus far. My current workflow only uses the jncep epub
subcommand though, so there may still be dragons here.
Thank you for your feedback.
I will update the requirements and test the other commands with the new asks version.
Describe the bug When invoking jncep with python 3.12, a TypeError is always thrown by
import asks
:The issue is that jncep is installed with asks 2.4.12 which doesn't have the commit which fixes this issue. I believe upgrading to asks 3.0.0 should fix the problem, but I'm unsure if there are breaking changes in the asks library between 2.4.12 and 3.0.0.
Expected behavior jncep should work as it has with previous versions of python.
To Reproduce
python -m venv jncep-venv
source jncep-venv/bin/activate.fish
pip install jncep
jncep --help
Environment (please complete the following information):