gvne / spleeterpp

A C++ Inference library for the Spleeter project
MIT License
162 stars 33 forks source link

Included tensorflow incompatible with older mac editions? #16

Closed MeijisIrlnd closed 4 years ago

MeijisIrlnd commented 4 years ago

oh god its me again, hope you're doing well and keeping safe etc! So my hdd corrupted yesterday, meaning I had to rebuild ALL my libraries I was using in my project, just going to include spleeterpp, but at runtime it gave me: DYLD: Symbol not found: ____chkstk_darwin, I'm on OSX 10.13 (high sierra), but I didn't have this issue last time, I think because I built it before the tensorflow binary got included with the rest of the code! Is my best course of action here to rebuild the tensorflow_cc binary, or is it something else I'm missing?

gvne commented 4 years ago

Hi @MeijisIrlnd and sorry for your loss ! It must indeed be a problem with the built tensorflow.

What I can suggest is instead on relying on tensorflow_cc, try the develop branch with the spleeter_enable_filter option to OFF when generating the solution:

cmake -GXcode -Dspleeter_enable_filter=OFF ..

The thing is that the develop branch no longer relies on the tensorflow_cc library but instead uses the tensorflow C API. The cmake scripts will download it for you here This hasn't been released yet because it lacks of documentation but it should work just as before .

Hope this helps !

MeijisIrlnd commented 4 years ago

Ughhh I'm struggling on building this, would you be able to give me a step by step? I've done git clone, git checkout origin/develop and git pull origin develop, then mkdir build && cd build, but when I run the cmake command above, I get Screen Shot 2020-04-24 at 16 27 21

gvne commented 4 years ago

I've never experienced an error like that before. Are you able to build dummy a C++ source file with Xcode ? It looks like there are no C++ complier available on your system.

MeijisIrlnd commented 4 years ago

Yeah I am, and gcc and g++ are on the path, super weird right? (Edit: for some reason it works today, I guess a restart and dropping the -GXcode sorted it??)

gvne commented 4 years ago

The -GXcode forces to use Xcode to compile the projet. My guess is that CMake can't find it. If you don't use it for your project using gcc is perfectly fine

MeijisIrlnd commented 4 years ago

Yeah so it all built ok, tensorflow included! Thanks so much for your help, I mean classic me I'm struggling to include spleeter with Juce but I'm sure I'll get there, stay safe dude!

gvne commented 4 years ago

If you want to check a juce integration you can check this or even this out.
For the plugin version, build instruction were discussed in an issue. Hope that helps !

Don't hesitate to close the issue when you're done

MeijisIrlnd commented 4 years ago

OO having a look at these unreal thank you!! I'm getting dyld: Library not loaded: @rpath/libtensorflow.1.dylib Referenced from: /Users/sylmorrison/Documents/Dev/TestTensorflow/Builds/MacOSX/build/Debug/TestTensorflow.app/Contents/MacOS/TestTensorflow Reason: image not found at runtime, but it LOOKS like the post build shell script might do something in the vein of fixing that? (Also will close in a sec sorry just wanted to clarify on that)

MeijisIrlnd commented 4 years ago

You are an actual saint, it builds and runs, thank you so so much!

gvne commented 4 years ago

You are very welcome ! Have fun :)

peanutismint commented 1 year ago

Hey guys, apologies for hijacking this thread but I'm experiencing similar problems compiling with gcc (even though it shows as installed).

I'm actually hoping to compile the code and output as an AU (Audio Unit) plug-in instead of a VST so I can run it on my iPad under iOS. If anyone would have suggestions on how to achieve that I'd be most grateful (current issues I'm experiencing are documented in this Reddit thread).