gvwilson / sdxjs

Software Design by Example with JavaScript
Other
49 stars 12 forks source link

Fix info/mccole.py so that the PDF can be built again #31

Closed juananpe closed 1 year ago

juananpe commented 1 year ago

Last commit in info/mccole.py broke the PDF generation process (due to missing variables title, tagline and author) It can be fixed passing those values from main in config.py:

if __name__ == "__main__":
    main(sys.argv, abbrev, title, tagline, author)

but surely there is a smarter way of fixing this problem:

 make pdf
ivy build && touch docs/index.html
[08:44:23]   ·   Rendered:    28   ·   Written:     0   ·   Time:   4.44 sec
python ./bin/single.py \
    --head info/head.html \
    --foot info/foot.html \
    --root docs \
    --title "$(python ./config.py --title)" \
    --tagline "$(python ./config.py --tagline)" \
    > docs/all.html
Traceback (most recent call last):
  File "/opt/sdxjs/en/./config.py", line 86, in <module>
    main(sys.argv, abbrev)
  File "/opt/sdxjs/en/info/mccole.py", line 78, in main
    print(title)
NameError: name 'title' is not defined. Did you mean: 'tuple'?
Traceback (most recent call last):
  File "/opt/sdxjs/en/./config.py", line 86, in <module>
    main(sys.argv, abbrev)
  File "/opt/sdxjs/en/info/mccole.py", line 76, in main
    print(tagline)
NameError: name 'tagline' is not defined
python ./bin/html2tex.py \
    --head info/head.tex \
    --foot info/foot.tex \
    < docs/all.html \
    > docs/sdxjs-2022-10-26.tex
python ./config.py --latex > docs/config.tex
Traceback (most recent call last):
  File "/opt/sdxjs/en/./config.py", line 86, in <module>
    main(sys.argv, abbrev)
  File "/opt/sdxjs/en/info/mccole.py", line 72, in main
    print(f"\\title{{{title}}}")
NameError: name 'title' is not defined. Did you mean: 'tuple'?
make: *** [docs/sdxjs-2022-10-26.tex] Error 1