gvwilson / sdxjs

Software Design by Example with JavaScript
Other
58 stars 13 forks source link

Toggleable Sidebar #34

Open rrcobb opened 1 year ago

rrcobb commented 1 year ago

Issue: https://github.com/gvwilson/sdxjs/issues/32 Ref: https://github.com/gvwilson/sdxjs/pull/33

Adds a button to hide / show the sidebar.

This PR is stacked on top of the fixed-width sidebar PR. Compare just the diff that adds the JS

gvwilson commented 1 year ago

I like the toggleable sidebar, but other people have suggested stacking the ToC on top of the content for mobile devices; I've also made a few changes to your changes to mccole.css (thanks for those) that may introduce some conflicts. I'll take another look at this one tomorrow - thank you for submitting it.

gvwilson commented 1 year ago

I've pushed changes that move the navigation to the top of the page for narrow devices - please check it out. If anyone has more thoughts on toggling, please let me know.