search

gvwilson / sdxjs

Software Design by Example with JavaScript
Other
49 stars 12 forks source link

fix: replace number 5 by number 6 #4

Closed juananpe closed 1 year ago

juananpe commented 1 year ago

I've spotted a typo in a SVG file. After editing and fixing it with Inkscape I've realized that the internal format of the SVG file has changed. The original one is somewhat compressed while the Inkscape edited version is not. Is it ok or should I follow another way?

I'm not sure why the SVG files are duplicated in en/docs and en/src...

gvwilson commented 1 year ago

Thanks for the PR. I use the desktop version of https://app.diagrams.net/ for all the diagrams rather thank Inkscape, both because the former is a simpler tool and because the PDFs it exports can be processed by LaTeX more reliably. (I've had lots of problems in the past with fonts in PDFs exported from Inkscape.) I also like the "rough" style option of apps.diagrams.net - I am a very poor artist, and I think the rough style reflects that :-)

Regarding the file duplication, the en/src folder holds all the source files, while en/docs is the output of the build process. You can rm -rf en/docs (or es/docs) and recreate it with a single command make build. I agree it's redundant, but it keeps the output of the static site generator completely separate from the input. I wish I could automatically generate PDF images from SVGs rather than storing the PDFs in the en/src folder, but all of my attempts to do that have failed: exporting from the app.diagrams.net GUI (or from Inkscape, back when I was using it) seems to be the only way to get usable PDFs reliably.

gvwilson commented 1 year ago

I've fixed the bug you spotted using app.diagrams.net and pushed the change - thank you.