gvwilson / sdxpy

Software Design by Example: a tool-based introduction with Python
https://third-bit.com/sdxpy/
Other
373 stars 55 forks source link

/db review #223

Closed gvwilson closed 1 year ago

gvwilson commented 1 year ago

cc @metawake

metawake commented 1 year ago

@gvwilson first issue in "Database" chapter is wrong import. The class is first named "class BasicRec" but is referred by test_db_original.py as "BasicExperiment". That can be fixed at import time by "from record_original import BasicRec as BasicExperiment".

metawake commented 1 year ago

@gvwilson Some small ongoing questions about the db chapter: https://github.com/gvwilson/sdxpy/issues/239