gvwilson / tidyblocks

A blocks-based interface for tidy data manipulation and analysis.
Other
82 stars 28 forks source link

Creating language-specific workspace pages. #332

Closed gvwilson closed 4 years ago

gvwilson commented 4 years ago

The original comment is out of date - see "I've pushed more changes" below.

DarkMetroid commented 4 years ago

Looks good, much prefer this approach.

Just to confirm, /en/index.html will need to be handled by Jekyll (using a front matter/permalink to do the routing)? To develop locally without Jekyll we'd need to also have an index.html without the Jekyll front matter syntax.

I feel like that makes sense, and the duplication in index files there is unavoidable if we want to work locally and do routing via. Jekyll.

I like the idea of a landing page for languages (or maybe we could just integrate it as a dropdown on the menu bar that redirects), just obviously forces us to run Jekyll during development. That doesn't seem like an unreasonable thing to require though.

gvwilson commented 4 years ago

I've pushed some more changes that reorganize things so we don't need Jekyll on the TidyBlocks interface page:

  1. Each language now has a sub-directory ('en', 'es', etc.).
  2. That sub-directory contains a copy of index.html (the TidyBlocks interface page localized to that language thanks to the URL containing the language code).
  3. I have removed the language guessing, since each language has its own index.html and we can just hardwire the language into it.
  4. The sub-directory also contains the help files for that language. (Right now these are only present for 'en', but I hope we will get translations.) Note that the help files include the glossary and the FAQ.
  5. The top level has the blog (which I doubt we'll ever translate), the license (ditto), the Code of Conduct (maybe?), the list of authors (unlikely). If we do translate any of these files, it will be easy to move them down into language directories.
  6. I've adjusted the URLs in the help menu in libs/ui/menuBar.jsx to point at the right things using relative paths.

Feedback would be very welcome. cc @DarkMetroid @MayaGans @demar01

DarkMetroid commented 4 years ago

I like the plan, makes sense.