Closed gvwilson closed 4 years ago
Looks good, much prefer this approach.
Just to confirm, /en/index.html
will need to be handled by Jekyll (using a front matter/permalink to do the routing)? To develop locally without Jekyll we'd need to also have an index.html
without the Jekyll front matter syntax.
I feel like that makes sense, and the duplication in index files there is unavoidable if we want to work locally and do routing via. Jekyll.
I like the idea of a landing page for languages (or maybe we could just integrate it as a dropdown on the menu bar that redirects), just obviously forces us to run Jekyll during development. That doesn't seem like an unreasonable thing to require though.
I've pushed some more changes that reorganize things so we don't need Jekyll on the TidyBlocks interface page:
index.html
(the TidyBlocks interface page localized to that language thanks to the URL containing the language code).index.html
and we can just hardwire the language into it.libs/ui/menuBar.jsx
to point at the right things using relative paths.en/guide.md
which seems a bit redundant now, but not having a root page for the documentation felt weird too.Feedback would be very welcome. cc @DarkMetroid @MayaGans @demar01
I like the plan, makes sense.
The original comment is out of date - see "I've pushed more changes" below.