gw0kin / gnome2-globalmenu

Automatically exported from code.google.com/p/gnome2-globalmenu
GNU General Public License v2.0
0 stars 0 forks source link

Not compatible with gnome-shell 3.1.90 #667

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.Install latest gnome-shell-3.1.90 in Ubuntu or Fedora
2.Try to enable extension

What is the expected output?
Global Menu should work as expected 

What do you see instead?
missing init and enable functions 

What version of the Global Menu are you using? On what operating system?

Latest git

What version of Vala are you using? (if your Global Menu is built from git)
0.13.3

Please provide any additional information below.

Original issue reported on code.google.com by mikkilin...@gmail.com on 4 Sep 2011 at 2:15

GoogleCodeExporter commented 9 years ago
interesting. Do you know of any changes of the extension system in 3.1.90 from 
3.0?

Original comment by rainwood...@gmail.com on 4 Sep 2011 at 4:15

GoogleCodeExporter commented 9 years ago
Not exactly. But I have downloaded latest extensions provided by gnome from  
git http://git.gnome.org/browse/gnome-shell-extensions and they are working 
fine. Looked in to extension.js file from working extensions. There are some 
new functions like init, enable and disable functions added into latest 
extensions.

When I tried to enable GlobalMenu extension it was trowing an error that init 
functions is missing. I have added a dummy init function in to code and tried 
to enable again. This time I hove got an error that enable function missing. 
Since I am not coder I don't have any idea what I need to write in these 
functions :(

Original comment by mikkilin...@gmail.com on 4 Sep 2011 at 6:12

GoogleCodeExporter commented 9 years ago
Thanks a lot. This information shall directly lead to a fix. I'll just have to 
find the time to work on it. 

Original comment by rainwood...@gmail.com on 4 Sep 2011 at 11:58

GoogleCodeExporter commented 9 years ago
I've subitted the pull request on github to fix this issue.
Anyway, I attached the patch here, too.

Original comment by lorenx...@gmail.com on 21 Sep 2011 at 11:18

Attachments:

GoogleCodeExporter commented 9 years ago
Has the complete patch set been merged in the git tree? 

Gnome 3.2 has landed in Archlinux, and the applied patches didn't make the 
global menu work here. 

Original comment by flx.b...@gmail.com on 2 Oct 2011 at 7:21

GoogleCodeExporter commented 9 years ago
Oh well, the extension has been deactivated during the update transition. I 
manually reactivated it via gnome-tweak-tool and everything is working again :)

Original comment by flx.b...@gmail.com on 2 Oct 2011 at 8:04