gw0kin / gnome2-globalmenu

Automatically exported from code.google.com/p/gnome2-globalmenu
GNU General Public License v2.0
0 stars 0 forks source link

Firefox tracker bug #95

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Just a tracker bug to drop some Firefox observations:
On Hardy Heron with lastest FF 3.0 and the latest ubuntu-packaged version
of Gnomenu, the menu is painted with the panel color. Does it hint at
future compatibility?
I know that Mozilla has done some OS integration work for 3.0, but I
thought they didn't have time to make further changes to the code to detach
the menu. 

Does it need a lot more work to detach the menu as it's already painted by
the panel ?

Original issue reported on code.google.com by pierre.s...@gmail.com on 21 May 2008 at 9:08

GoogleCodeExporter commented 9 years ago
No it is not painted by the panel.
Did you check if it was because you set the theming color of menu bar to your 
panel's
color?

Original comment by rainwood...@gmail.com on 21 May 2008 at 11:15

GoogleCodeExporter commented 9 years ago
A picture is worth 100 words

Original comment by pierre.s...@gmail.com on 21 May 2008 at 11:25

Attachments:

GoogleCodeExporter commented 9 years ago
And another one to make things look like even more bizarre
 (Notice the red part on the left part of the panel)

Original comment by pierre.s...@gmail.com on 21 May 2008 at 11:27

Attachments:

GoogleCodeExporter commented 9 years ago
It might be related to #84 and for the second screenshot to a defect in the 
Mac4Lin
theme.
I've contacted the author to beta-test the next version and ensure it plays 
nice with
gnomenu.

Original comment by pierre.s...@gmail.com on 21 May 2008 at 11:30

GoogleCodeExporter commented 9 years ago
Yes, I can confirm this bizarre effect. I don't have time to go into it.
It seems that Firefox is creating a GtkMenuBar, but it is not setting the 
menuitems
as the GtkMenuBar's child. or Firefox is creating a GtkMenuBar, but only 
obtains its
style to draw its XUL widgets.

I think the second one explains all the phenomena.

Original comment by rainwood...@gmail.com on 22 May 2008 at 12:01

GoogleCodeExporter commented 9 years ago
Just clarified the bug title

Original comment by pierre.s...@gmail.com on 13 Jan 2009 at 4:38

GoogleCodeExporter commented 9 years ago
They're open to patches as GM doesn't require to patch GTK anymore

Original comment by pierre.s...@gmail.com on 13 Jan 2009 at 9:38

GoogleCodeExporter commented 9 years ago
Issue 182 has been merged into this issue.

Original comment by pierre.s...@gmail.com on 31 Jan 2009 at 2:56

GoogleCodeExporter commented 9 years ago
I'm not a programmer, but I think that creating a Firefox extension to hide the 
menu
bar and use the global menu bar would be easier than patching XUL. There's 
already an
extension to hide the menu bar. Just an idea.

Original comment by daniel...@gmail.com on 30 Mar 2009 at 1:25

GoogleCodeExporter commented 9 years ago
Issue 394 has been merged into this issue.

Original comment by rainwood...@gmail.com on 9 Apr 2009 at 6:41

GoogleCodeExporter commented 9 years ago
https://wiki.mozilla.org/XUL:Menus
This gives an insight on how Firefox handles the Mac situation for anyone 
interested
in patching the Linux version of GlobalMenu.
By looking at the page history , you may find who added the text and get some 
help in
coding it.

Original comment by pierre.s...@gmail.com on 29 Apr 2009 at 6:26

GoogleCodeExporter commented 9 years ago
https://wiki.mozilla.org/User:Josh

Original comment by pierre.s...@gmail.com on 29 Apr 2009 at 6:34

GoogleCodeExporter commented 9 years ago
Issue 577 has been merged into this issue.

Original comment by pierre.s...@gmail.com on 20 Mar 2010 at 2:53

GoogleCodeExporter commented 9 years ago

Original comment by pierre.s...@gmail.com on 1 May 2010 at 9:13

GoogleCodeExporter commented 9 years ago
I've started a Firefox extension that walks the Firefox XUL menu from 
Javascript and creates the Globalmenu XML from it: 
http://gitorious.org/firefox-gnome-globalmenu/firefox-gnome-globalmenu .

Note that it's mostly a prototype. For example,
a) The menus eventually desync (deactivating then activating the Firefox window 
fixes it as updating the menus on "focus in" event is hardcoded). Most 
noticeable cut/copy/paste sensitiveness. This can be fixed, just requires more 
through understanding of XUL command element.
b) Some menus do not work at all (Bookmarks, Encoding, Help) because Firefox 
expects me to call menu_shown/menu_hidden event handlers. I've implemented that 
only for the History menu.
c) There's a racy condition where the extension will overwrite some other 
window's global menu (including other application's ones). Didn't happen to me 
though. I need a better way to get the Firefox window XID.
d) Only gtk stock icons used.
e) Sometimes it breaks Alt+mnemonics and F10 on a _global_ level. Seems I'm 
triggering a globalmenu applet bug, but I'm yet to consistently reproduce it. 
Accelerators do work :).

The extension has some native code which has to be built (so you need gecko 
sdk, etc.). Check src/Makefile . The native code handles X11 stuff; most of the 
logic (including XML generating one) is implemented in JavaScript.

Original comment by javispe...@gmail.com on 4 Oct 2010 at 9:10

GoogleCodeExporter commented 9 years ago
Thank you for the good work! I'm going to check it out this weekend if possible.

b) is similiar to java swt, where one needs to invoke some other signals to 
rebuild the menu.
d) that's already good enough. none stock icons are serialized with gtk 
convensions encoded in base64, then embbed in the xml; a complicated and slow 
process.
e) It sounds like a bug fixed in the git head but not in the current released 
version.

Original comment by rainwood...@gmail.com on 5 Oct 2010 at 2:30

GoogleCodeExporter commented 9 years ago
I've already fixed most of the glaring issues
a) Cut/Copy/Paste/Stop/Refresh sensitiveness now stays in sync.
b) Bookmarks menu works now.
c) Get the Window XID the "proper" way.
d) Render & base64_encode the icons that do not come from stock Gtk+. There's 
currently a per-window cache of base64'd icons that should be extended to 
per-process, ideally.
e) That was Issue 500.
As the current approach rebuilds the entire menu every time there's an event 
that "could" change some item's contents/sensitivity, performance is an issue 
(specially with lots of bookmarks & favicons); as a workaround it batches 
events for 500ms then updates if required.

Original comment by javispe...@gmail.com on 7 Oct 2010 at 8:53

GoogleCodeExporter commented 9 years ago
This might also interest the Ubuntu effort for application menus.

Original comment by pierre.s...@gmail.com on 8 Oct 2010 at 9:19

GoogleCodeExporter commented 9 years ago
the firefox globalmenu plugin works very well, thanks javispedro!

Now i am using firefox instead of opera..

Original comment by jason5...@gmail.com on 11 Oct 2010 at 2:01

GoogleCodeExporter commented 9 years ago
A little problem, seems firefox-globalmenu miss something for non-english menu.

see the attachment. and the keyboard shotcut will not woring. means i can not 
use ALT+F to access to _File menu. But shotcut works fine in english menu. In 
chinese it suppose to be "文件(_F)",also have a shotcut though.

Original comment by jason5...@gmail.com on 12 Oct 2010 at 7:28

Attachments:

GoogleCodeExporter commented 9 years ago
How can I exactly install this firefox fix?
And why must I create the globalmenu.xpi file?
Can somebody upload his or her file, because I can't create this file with the 
terminal. The terminal says: "make: *** src: No such file or directory.  End."
And nothing happens. What can I do?
Thanks in advance!

Original comment by Timme....@gmail.com on 20 Oct 2010 at 5:26

GoogleCodeExporter commented 9 years ago
jason52lh: I think I fixed that in latest Git.

Original comment by javispe...@gmail.com on 23 Oct 2010 at 2:45

GoogleCodeExporter commented 9 years ago
How about making a binary .deb file (and maybe a launchpad ppa), so that us 
non-programmers can install this on our systems.

Original comment by Cassie...@gmail.com on 25 Oct 2010 at 5:17

GoogleCodeExporter commented 9 years ago
yeah i second the idea to provide a test xpi file.. i have all the gtk 
development files and xulrunner-dev and xulrunner-dev-1.9.2 (something like)

but it won't build it

Original comment by ikeah...@gmail.com on 27 Oct 2010 at 5:53

GoogleCodeExporter commented 9 years ago
Because of the binary components, any binary distribution should have your 
distro in mind. Arch is already packaging it AFAIK.

(I guess I should get a proper project home for this, Gitorious is not 
enough...).

Original comment by javispe...@gmail.com on 3 Nov 2010 at 8:59

GoogleCodeExporter commented 9 years ago
Hi, javispedro, there is another little problem: 

some icons in firefox globale menu will be larger then normal. but in firefox 
menu it's alright.

Original comment by jason5...@gmail.com on 5 Nov 2010 at 6:05

Attachments:

GoogleCodeExporter commented 9 years ago
javispedro,

So you are aware I would just like to add that your extension doesn't currently 
work in Firefox 4 beta6.  

Original comment by earthqua...@gmail.com on 6 Nov 2010 at 5:02

GoogleCodeExporter commented 9 years ago
Hope soon add firefox 4.0 support.

Original comment by jason5...@gmail.com on 11 Nov 2010 at 8:09

GoogleCodeExporter commented 9 years ago
In case you are still using this....

Since Gentoo pushed Firefox 9 to 'stable', I've finally been forced to update 
my extension to work with newer Firefoxes. I have also fixed some issues and 
made the extension hide the menu bar on its own, so there is no longer need to 
install "Hide menu bar" or similar extensions for that.

As an added bonus, it should now install under Thunderbird. Albeit it doesn't 
work very well there.

Please read the INSTALL file because building is slightly harder than previous 
versions. Also, the install.rdf limits the extension to Firefox/Thunderbird 9 
only, but I don't see any reason it should not work on 10, so if you are 
feeling adventurous, change the rdf and try it.

Original comment by javispe...@gmail.com on 29 Jan 2012 at 2:04