gw2-api / issues

Issue tracker for the Guild Wars 2 API
https://discord.gg/zqeHCEg
16 stars 0 forks source link

`/v2/skills`: Profession specific skills (tomes, shrouds, "bundles") missing #26

Open gw2princeps opened 2 years ago

gw2princeps commented 2 years ago

Current Behavior

Most - if not all - profession specific "transformation" skills are not exposed in the API. I think it is related to them being classified as "bundle". Regardless of that - these skills are crucial just like normal skills for creating user friendly guide websites.

Example (Epilogue: Ashes of the Just - firebrand tome f1 skill 5): https://api.guildwars2.com/v2/skills?ids=42898

{
  "text": "all ids provided are invalid"
}

Expected Behavior

The query should return:

{
  "name": "Epilogue: Ashes of the Just",
  "professions": ["Guardian"],
  "description": "Recall the memory of fallen heroes, granting allies the searing blades of justice.",
  "icon": "https://render.guildwars2.com/file/EC05420EAE5445A7069409B54D4502ED36BDF10A/1770477.png",
  "categories": ["Tome"],
  "facts": [
    {
      "text": "Recharge",
      "type": "Recharge",
      "icon": "https://render.guildwars2.com/file/D767B963D120F077C3B163A05DC05A7317D7DB70/156651.png",
      "value": 12
    },
    {
      "text": "Apply Buff/Condition",
      "type": "Buff",
      "icon": "https://render.guildwars2.com/file/EC05420EAE5445A7069409B54D4502ED36BDF10A/1770477.png",
      "duration": 10,
      "status": "Ashes of the Just",
      "description": "Your next strike burns with justice.",
      "apply_count": 3
    },
    {
      "text": "Apply Buff/Condition",
      "type": "Buff",
      "icon": "https://render.guildwars2.com/file/B47BF5803FED2718D7474EAF9617629AD068EE10/102849.png",
      "duration": 3,
      "status": "Burning",
      "description": "Deals damage every second; stacks intensity.",
      "apply_count": 1
    },
    {
      "text": "Number of Allied Targets",
      "type": "Number",
      "icon": "https://render.guildwars2.com/file/BBE8191A494B0352259C10EADFDACCE177E6DA5B/1770208.png",
      "value": 5
    },
    {
      "text": "Interval",
      "type": "Time",
      "icon": "https://render.guildwars2.com/file/B75E91EB22E0DFCC1D08030204055946506D56F6/1770206.png",
      "duration": 1
    },
    {
      "text": "Radius",
      "type": "Distance",
      "icon": "https://render.guildwars2.com/file/B0CD8077991E4FB1622D2930337ED7F9B54211D5/156665.png",
      "distance": 600
    }
  ]
}

Steps To Reproduce

No response

Happening since

Release of the game? At least for as long as I am working on this which is ~2019

Anything else?

We put together a bunch of json file containing at least the firebrand tome skills: https://github.com/discretize/discretize-gw2api/tree/main/api/skills

With the rise of other classes that also heavily depend on profession specific skills it would take off a major workload off our shoulders - creating these API definitions is time consuming and not fun.

If there is anything I can do to help fix this problem, please let me know!

shehi commented 8 months ago

Re-reporting, originally from https://github.com/arenanet/api-cdi/issues/643

The following skills are not available in /v2/skills:

Throw Magnetic Bomb (49112) Soul Stone Venom (49052) Detonate Plasma (49063) Unstable Artifact (49123)

Also the case for some other non-raid stolen skills: 1113, 1114, 1119, 1116, 1149, 1134, 1132, 1120, 1121, 1126, 1127, 1130, 1133, 1135, 1146, 1138, 1144

shehi commented 8 months ago

I can confirm that not a single Firebrand tome skill is available in API.