gw2-api / issues

Issue tracker for the Guild Wars 2 API
https://discord.gg/zqeHCEg
15 stars 0 forks source link

`/v2/skills`: Some skill facts are not translated #27

Open gw2princeps opened 2 years ago

gw2princeps commented 2 years ago

Current Behavior

For the skills endpoint, the api returns a facts array. Some facts don't have a translated text property, instead the english text is returned. I am not sure which types in total are effected, at least Range, ComboField and Recharge.

This happens for any language that is not english.

Example: https://api.guildwars2.com/v2/skills?ids=5548&lang=de

Expected Behavior

The endpoint should return all text strings translated to the selected language.

 {
-  "text": "Recharge",
+  "text": "Wiederaufladung",
   "type": "Recharge",
   "icon": "https://render.guildwars2.com/file/D767B963D120F077C3B163A05DC05A7317D7DB70/156651.png",
   "value": 6
 },
 {
   "text": "Schaden",
   "type": "Damage",
   "icon": "https://render.guildwars2.com/file/61AA4919C4A7990903241B680A69530121E994C7/156657.png",
   "hit_count": 1,
   "dmg_multiplier": 0.525
 },

Steps To Reproduce

No response

Happening since

No response

Anything else?

No response

Archomeda commented 2 years ago

While the zh lang shouldn't be relied upon (because it's mostly incomplete), it also seems to happen with other languages indeed.