search

gw2efficiency / issues

All bug reports, planned features, ideas & milestones for gw2efficiency
79 stars 6 forks source link

Hardcode achievements to handle missing EoD titles #1640

Open hoosierc opened 2 years ago

hoosierc commented 2 years ago

Achievements missing from https://gw2efficiency.com/account/unlock-statistics?filter.category=333

Titles missing from https://gw2efficiency.com/account/unlock-statistics?filter.key=titles

I'm not sure how, but it looks like killproof.me is able to track these so maybe it's just an issue of them not being automatically discoverable in the way other achievements/titles are and they had to hardcode their IDs or something?

queicherius commented 2 years ago

The achievements are tracked in the "completion" endpoint, and we actually do aggregate how many people have it completed, for example "Gaze into the Void" is completed by 3802 players.

The reason it's not showing up in the interface is that the achievement itself is not in the API, e.g. https://api.guildwars2.com/v2/achievements/6526 should be "Gaze into the Void" but it's not there (anymore). Killproof probably hardcodes those. We could to the same, but I just wish the API would have them :(

queicherius commented 1 year ago

Same issue with "Cod Swimming Amongst Mere Minnows"