Emboldened edge cases - Githubissues

gw2scratch / evtc

Analysis and management of Guild Wars 2 EVTC logs from arcdps.

https://gw2scratch.com/tools/

MIT License

59 stars 24 forks source link

Emboldened edge cases #199

Open Sejsel opened 1 year ago

Sejsel commented 1 year ago

[ ] Emboldened can be legitimately applied in the middle of a fight in case the fight is ongoing while the Emboldened wing changes, we do not currently handle this (and the log processing outright fails)
[ ] Emboldened can be applied at the end of a log, we need to ignore it. This is especially notable if going from a CM fight to a normal fight in a wing that does not have Emboldened disabled.

Sejsel commented 1 year ago

In c435f69, I fixed the processing outright failing in case there is no initial buff with emboldened, but it appears later in the fight. We still need to handle these two cases correctly, though.