search

gwaldron / osgearth

3D Maps for OpenSceneGraph / C++14
https://www.pelicanmapping.com/home-1/opensource
Other
1.48k stars 774 forks source link

Reset OGR order to standard; #2458

Closed MCA4213 closed 6 months ago

MCA4213 commented 6 months ago

This commit allows: 1) Reset OGR geometries order to standard order. 2) Add geometryToIsoWKT function. (the geometryFromWKT is capable to read both wkt and isoWkt).

I have tested point, line, polygon geometries and are still loading correctly. image

gwaldron commented 6 months ago

Thanks for the PR! Question: is there any reason not to default to ISO WKT? Should we just make geometryToWKT redirect to geometryToIsoWKT?

MCA4213 commented 6 months ago

I think it is possible to use only IsoWkt, because the old function is used for compatibility. Take a look on this: https://gdal.org/api/vector_c_api.html

I am using spatialite and postgis and both of them use the iso format. (Pg has an additional ewkt that is a little bit similar but with srid included: not a standard i think).

Le dim. 3 mars 2024, 3:44 PM, Glenn @.***> a écrit :

Thanks for the PR! Question: is there any reason not to default to ISO WKT? Should we just make geometryToWKT redirect to geometryToIsoWKT?

— Reply to this email directly, view it on GitHub https://github.com/gwaldron/osgearth/pull/2458#issuecomment-1975185480, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABW5O2PMXOMO6VWICJ76K3DYWMZL5AVCNFSM6AAAAABEDLHNA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZVGE4DKNBYGA . You are receiving this because you authored the thread.Message ID: @.***>