gwaldron / osgearth

3D Maps for OpenSceneGraph / C++14
https://www.pelicanmapping.com/home-1/opensource
Other
1.48k stars 774 forks source link

BUG - OSG version is not retrieved #2464

Closed AhmedAredah closed 6 months ago

AhmedAredah commented 6 months ago

Describe the bug Building the library on windows does not get the OSG version number.

To Reproduce Steps to reproduce the behavior:

  1. Build the library on Win 11 64 bit. command:

cmake -G "Visual Studio 16 2019" -A x64 .. -DGEOS_LIBRARY_DEBUG:FILEPATH="C:/Program Files/GEOS/lib/geos_cd.lib" -DOSGSHADOW_LIBRARY_DEBUG:FILEPATH="C:/Program Files/OSG/lib/osgShadowd.lib" -DOSGUTIL_LIBRARY _DEBUG:FILEPATH="C:/Program Files/OSG/lib/osgUtild.lib" -DOSGSIM_LIBRARY_DEBUG:FILEPATH="C:/Program Files/OSG/lib/osgSimd.lib" -DOSGVIEWER_LIBRARY:FILEPATH="C:/Program Files/OSG/lib/osgViewer.lib" -DOSGSIM_LIBRA RY:FILEPATH="C:/Program Files/OSG/lib/osgSim.lib" -DCMAKE_INSTALL_PREFIX:PATH="C:/Program Files/OSGEARTH" -DOSGTEXT_LIBRARY:FILEPATH="C:/Program Files/OSG/lib/osgText.lib" -DOSG_DIR:PATH="C:/Program Files/OSG" - DOSGVIEWER_LIBRARY_DEBUG:FILEPATH="C:/Program Files/OSG/lib/osgViewerd.lib" -DOSGGA_LIBRARY:FILEPATH="C:/Program Files/OSG/lib/osgGA.lib" -DOSG_GEN_INCLUDE_DIR:PATH="C:/Program Files/OSG/include" -DOSGTEXT_LIBRA RY_DEBUG:FILEPATH="C:/Program Files/OSG/lib/osgTextd.lib" -DOSGUTIL_LIBRARY:FILEPATH="C:/Program Files/OSG/lib/osgUtil.lib" -DOSGMANIPULATOR_LIBRARY_DEBUG:FILEPATH="C:/Program Files/OSG/lib/osgManipulatord.lib" -DOSGDB_LIBRARY_DEBUG:FILEPATH="C:/Program Files/OSG/lib/osgDBd.lib" -DOSG_LIBRARY:FILEPATH="C:/Program Files/OSG/lib/osg.lib" -DOPENTHREADS_LIBRARY_DEBUG:FILEPATH="C:/Program Files/OSG/lib/OpenThreadsd.lib" -D OSGMANIPULATOR_LIBRARY:FILEPATH="C:/Program Files/OSG/lib/osgManipulator.lib" -DOSG_INCLUDE_DIR:PATH="C:/ProgramFiles/OSG/include" -DOSG_LIBRARY_DEBUG:FILEPATH="C:/Program Files/OSG/lib/osgd.lib" -DOPENTHREADS_L IBRARY:FILEPATH="C:/Program Files/OSG/lib/OpenThreads.lib" -DOSGDB_LIBRARY:FILEPATH="C:/Program Files/OSG/lib/osgDB.lib" -DOSGSHADOW_LIBRARY:FILEPATH="C:/Program Files/OSG/lib/osgShadow.lib" -DGDAL_INCLUDE_DIR= "C:/Program Files/gdal/include" -DGDAL_LIBRARY="C:/Program Files/gdal/lib/gdal.lib" -DCMAKE_BUILD_TYPE=Release

  1. the cmakeCache has the value of OPENSCENEGRAPH_VERSION = ..

Expected behavior It should get the OSG version. I am using OSG version 3.6.5 here

Screenshots image

Desktop (please complete the following information):

AhmedAredah commented 6 months ago

I manually defined the version, does it have any impact?

image

gwaldron commented 6 months ago

If might be broken because of -DOSG_INCLUDE_DIR:PATH="C:/ProgramFiles/OSG/include" instead of -DOSG_INCLUDE_DIR:PATH="C:/Program Files/OSG/include"

AhmedAredah commented 6 months ago

@gwaldron oh thank you for noticing it