search

gwaldron / osgearth

3D Maps for OpenSceneGraph / C++14
https://www.pelicanmapping.com/home-1/opensource
Other
1.48k stars 774 forks source link

For CesiumNative, use `ktx` library instead of `ktx_read` #2596

Closed yunusyurtturk closed 1 month ago

yunusyurtturk commented 1 month ago

Updated content to reflect changes made by cesium-native side. . Otherwise, -DOSGEARTH_BUILD_CESIUM_NODEKIT=ON type cmake configurations were complaining about being ktx_read not found.

Cesium-native is using ktx instead of ktx_read for a while

Check cesium-native commits: https://github.com/CesiumGS/cesium-native/commit/dd35563ff874e05d3a616cb0a852f36216e8673f

https://github.com/CesiumGS/KTX-Software/pull/1

yunusyurtturk commented 1 month ago

This PR fix the related update made by cesium-native side, however there are things to support versions never than cesium-native v0.33.0

There are breaking changes to be fixed, like newly introduced AppData parameter here:

https://github.com/CesiumGS/cesium-native/blame/c36ddc72d23588573470be6eddf232c80c18d0cd/CesiumIonClient/src/Connection.cpp#L250

yunusyurtturk commented 1 month ago

This PR fix the related update made by cesium-native side, however there are things to support versions never than cesium-native v0.33.0

There are breaking changes to be fixed, like newly introduced AppData parameter here:

https://github.com/CesiumGS/cesium-native/blame/c36ddc72d23588573470be6eddf232c80c18d0cd/CesiumIonClient/src/Connection.cpp#L250

The problem is known, https://github.com/gwaldron/osgearth/discussions/2558 by @jasonbeverage

jasonbeverage commented 1 month ago

I've updated osgEarth cesium to use the latest version of cesium-native, v0.37.0. Thanks for pointing this out!