relative url in <NetworkLink><Link><href>rel.kml</href></Link></NetworkLink> broken

philipdumont commented 8 years ago

Please consider something like the attached patch.

As is, a relative link is looked for in the process's current working directory. It should be relative to the referrer -- the file containing the <NetworkLink> tag. The patch makes it so.

osgearth-2.7.0.patch.txt

gwaldron commented 8 years ago

Please submit code changes as a Pull Request. Thanks.

philipdumont commented 8 years ago

Er, how do I do that?

Note: I'm moderately conversant in mercurial. My knowledge of git is limited to the extent to which it resemble mercurial (and what little I gleaned just now to get as far as I did).

I got as far as:

clone repo (git clone https://github.com/gwaldron/osgearth.git)
create a branch (cd osgearth; git branch pdd_NetworkLink_relative_href_fix)
switch to branch (git checkout pdd_NetworkLink_relative_href_fix)
make edits
commit (git add ...; git commit).

Now what? I can't push, I can't find anything in "git help" about issuing a pull request, I can't find anything at github about how to issue a pull request. (Somewhere in faq, there's a list of instructions that include "issue a pull request", but it doesn't say how.) I see the "Pull Request" link on the github page, but as it's accessing the github repo, not my clone, what good is that?

Please advise.

On Thu, Jan 7, 2016 at 4:17 PM, Glenn notifications@github.com wrote:

Please submit code changes as a Pull Request. Thanks.

— Reply to this email directly or view it on GitHub https://github.com/gwaldron/osgearth/issues/683#issuecomment-169807614.

philipdumont commented 8 years ago

Pull request instructions found. Pull request submitted.

On Thu, Jan 7, 2016 at 4:59 PM, Phil Dumont phil@solidstatescientific.com wrote:

Er, how do I do that?

Note: I'm moderately conversant in mercurial. My knowledge of git is limited to the extent to which it resemble mercurial (and what little I gleaned just now to get as far as I did).

I got as far as:

clone repo (git clone https://github.com/gwaldron/osgearth.git)

create a branch (cd osgearth; git branch pdd_NetworkLink_relative_href_fix)

switch to branch (git checkout pdd_NetworkLink_relative_href_fix)

make edits

commit (git add ...; git commit).

Now what? I can't push, I can't find anything in "git help" about issuing a pull request, I can't find anything at github about how to issue a pull request. (Somewhere in faq, there's a list of instructions that include "issue a pull request", but it doesn't say how.) I see the "Pull Request" link on the github page, but as it's accessing the github repo, not my clone, what good is that?

Please advise.

On Thu, Jan 7, 2016 at 4:17 PM, Glenn notifications@github.com wrote:

Please submit code changes as a Pull Request. Thanks.

— Reply to this email directly or view it on GitHub https://github.com/gwaldron/osgearth/issues/683#issuecomment-169807614.

gwaldron / osgearth

relative url in <NetworkLink><Link><href>rel.kml</href></Link></NetworkLink> broken #683