search

gwastro / BBHX-waveform-model

GNU General Public License v3.0
1 stars 3 forks source link

replace bbhx.utils.transform and fix t_offset #1

Closed WuShichao closed 8 months ago

WuShichao commented 1 year ago

@ahnitz @spxiwh @ConWea This PR replaces the bbhx.utils.transform by using the latest development from https://github.com/gwastro/pycbc/pull/4289 and also corrects the offset time when doing relbin PE (the position of LISA in BBHx is not at the right position, not behind the Earth by 20 degrees, we need to correct its position for our multiband PE).

ahnitz commented 9 months ago

@WuShichao This has a conflict with the base plugin? can you rebase and verify that everything still works as expected. (also check why a conflict arose so you understand what the changes were).