search

gwastro / BBHX-waveform-model

GNU General Public License v3.0
1 stars 3 forks source link

Fix get length in time #15

Closed mj-will closed 4 months ago

mj-will commented 4 months ago

I've added a test for the get_waveform_filter_length_in_time.

It seems this doesn't work, since this test is failing, so this might need fixing.

mj-will commented 4 months ago

I've rewritten the function to use more specific functions in pycbc: https://github.com/gwastro/pycbc/blob/master/pycbc/waveform/waveform.py#L1037

mj-will commented 4 months ago

@WuShichao I think this ready