search

gwastro / BBHX-waveform-model

GNU General Public License v3.0
1 stars 3 forks source link

Add a basic test and CI #6

Closed mj-will closed 2 months ago

mj-will commented 3 months ago

Add a very basic test and CI

These should be updated in another PR since I'm unsure if the CI will run for this PR.

mj-will commented 2 months ago

@WuShichao do you have any option to run the CI I've added in this MR? (See https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks for details)

mj-will commented 2 months ago

After talking with @spxiwh, it seems this PR will likely need to be made from a branch on the main repo rather than my fork. I don't have permission to push to the repo, so I'll need someone else to that or to add me for the permissions.

spxiwh commented 2 months ago

Invite sent, let me know if it doesn't give you what you need

mj-will commented 2 months ago

Thanks @spxiwh, that seems to have changed my permissions for the main pycbc repo, but not for this one (I can't push or add e.g. labels for PRs). I'm guessing this one isn't included in those related to the Maintainers group.

spxiwh commented 2 months ago

Try again now, I've played with group settings.

mj-will commented 2 months ago

Thanks, that seems to have worked

WuShichao commented 2 months ago

Thanks, I have approved this https://github.com/gwastro/BBHX-waveform-model/pull/8 but I didn't see the CI test.