search

gwastro / PyCBC-Tutorials

Learn how to use PyCBC to analyze gravitational-wave data and do parameter inference.
116 stars 49 forks source link

Issue in Tutorial 0 section.2 read_frame() #30

Closed ibrooabri closed 1 year ago

ibrooabri commented 1 year ago

read_frame() gives out an error:

module 'lalframe' has no attribute 'FrSetMode'

I have run the code on the same colab notebook.

ahnitz commented 1 year ago

@ibrooabri Thanks for this report.

Lalsuite (which provides lalframe) put out a release that made breaking changes two days ago. This is a library we depend on. We have just patched this on our side to avoid the functions they've removed, but we'll need to put out a new release to fix this. The short-term alternative is to use the previous release of lalsuite. You can do this by requiring version 7.11. You can do this with 

pip install lalsuite==7.11

In place of the install without a version specified.

I'm hopeful we'll have a new release out soon, but hopefully this will help you out in the short term.

Thanks for raising this issue here as I'm sure others might hit it and it's helpful for them to see what the possible solution is!

ahnitz commented 1 year ago

@ibrooabri We have just made a new release, so if you reinstall the latest version of pycbc the problem should be fixed. If you have an open notebook you made need to tell it to upgrade pycbc when it installs it (i.e. if an existing installation already exists where you are running the notebook).

ibrooabri commented 1 year ago

Thank you very much. It is working perfectly fine now. That is a great help!