Loosen Code Climate checks

[cdcapano]

I think the checks in Code Climate are currently too draconian. This changes the following (I think anyway... not entirely should I got the right commands):

• increases the number of allowed function arguments from 5 to 10.
• increases the number of methods allowed for a class from 20 (the default) to 50.
• increases the number of lines allowed in a function from 25 (the default) to 100.
• turns off the cognitive complexity test.

I want to turn off the cognitive complexity test because it's not really well defined what it's doing. For example, in #17, Code Climate complained that this function had a cognitive complexity of 6, which was above the threshold of 5. I don't really know what that means, and I personally didn't find that function to be very hard to understand (granted, I'm biased, since I wrote it). Really, this is something that is the reviewers job to check.

For similar reasons I'm also tempted to turn off the cyclomatic complexity test, but can see how that might be able to provide feedback that a reviewer might not immediately catch.

[coveralls]

Pull Request Test Coverage Report for Build 112

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 40.528%

---

Totals
Change from base Build 102:	0.0%
Covered Lines:	1014
Relevant Lines:	2502

---

💛 - Coveralls

[cdcapano]

@duncanmmacleod poke

[duncanmmacleod]

@cdcapano, apologies for the delay, I've been on holiday. My only concern is disabling the cognitive complexity test. I think it is useful to have that test enabled, even if its hard to act on the results you get from it on codeclimate - just knowing that a method is cognitively complex will make one sit and think about it for a minute, even if no changes are made as a result (as I've just done for the method you linked in your opening post).

[cdcapano]

@duncanmmacleod Ok, fair enough... I've turned the cognitive complexity test back on.